Extensions: adjust specialname rules #78215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcouv
added
Area-Compilers
Feature - Extension Everything
ghost
added
the
untriaged
jcouv
force-pushed
the
extensions-special
branch
from
f859f22 to
ce6fd8b
Compare
AlekseyTs
reviewed
Apr 22, 2025
| !methodSymbol.ReturnsVoid || | ||
| methodSymbol.ParameterCount != 1) // Tracked by https://github.com/dotnet/roslyn/issues/76130 : Should we accept more than one parameter (in case new versions add more info)? | ||
| methodSymbol.ParameterCount != 1 || | ||
| !methodSymbol.HasSpecialName) |
|
Done with review pass (commit 1) |
jjonescz
approved these changes
Apr 23, 2025
This was referenced Apr 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following LDM 2025-04-16
The extension marker is emitted with specialname and we require it for recognizing it from metadata.
Implementation methods are emitted without specialname. Note: I chose not to check that when loading from metadata.
We also confirmed that a marker method from metadata should not be recognized if more than 1 parameter.
Relates to test plan #76130